innosetup: update to 6.4.3 #613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gitforwindowshelper[bot]](https://avatars.githubusercontent.com/in/246505?s=60&v=4){kind=small}
Signed-off-by: Matthias Aßhauer <mha1993@live.de>
Now that we run our CI jobs in a build matrix for both x86_64 and aarch64, we need separate names for the artifacts. Otherwise whichever job reaches the `actions/upload-artifacts` step second will fail, because an artifact of the same name already exists for this workflow run. Signed-off-by: Matthias Aßhauer <mha1993@live.de>
dscho
approved these changes
May 4, 2025
| @@ -96,7 +96,7 @@ jobs: | |||
| top_dir=$PWD && | |||
| cd "${{ matrix.directory }}" && | |||
| MAKEFLAGS=-j8 makepkg-mingw -s --noconfirm && | |||
| artifacts="$(basename "${{ matrix.directory }}")-artifacts" && | |||
| artifacts="$(basename "${{ matrix.directory }}")-artifacts-${{ matrix.architecture.name }}" && | |||
There was a problem hiding this comment.
Thank you for catching and fixing my mistake!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes git-for-windows/git#5614