Skip to content

Chinese Simplified for installer #611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

TC999
Copy link

@TC999 TC999 commented Apr 20, 2025

A friendly reminder for new contributors:

What is DCO sign-off? Why is it required?

DCO stands for Developer's Certificate of Origin.

We require all commits to be DCO signed-off in case we need to track down and handle legal and/or technical issues.

To DCO sign-off your commits, you could run the git-commit command with the -s option or just add a line in your commit message in this format:

        Signed-off-by: yourFirstName yourLastName <yourEmail@example.org>

For more information, check out how PRs are checked for DCO sign-off: https://github.com/probot/dco#how-it-works .

Thank you very much.

@TC999 TC999 changed the title innosetup: Add Chinese Simplfied Language ISL file Chinese Simplified for installer Apr 20, 2025
@dscho
Copy link
Member

dscho commented Apr 20, 2025

Thank you for your contribution @TC999!

However, Git for Windows merely consumes these translations from InnoSetup. We do not add our own versions here. I see two unofficial Chinese translations in that project: simplified and traditional. It would most likely make more sense to contribute there (specifically, see the information at https://jrsoftware.org/files/istrans/, a link that you even quoted in the added file), and to try to get the translation to a level where it can be included in the official InnoSetup versions, from which Git for Windows will then automatically consume it.

In that light, I do not want to merge it here (which would be premature before getting the official blessing of the InnoSetup project).

@dscho dscho closed this Apr 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants