Skip to content

portable: make sure that package-versions.txt is included #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dscho
Copy link
Member

@dscho dscho commented May 17, 2024

In git-for-windows/git#4955 it was pointed out that the i686 version ("32-bit") of Portable Git v2.45.1 is missing the package-versions.txt file.

While it is unclear why that happened (the logs of the -- embargoed -- build do not reveal any clue about this issue), let's at least ensure that it does not happen again.

/cc @mcgitty

In git-for-windows/git#4955 it was pointed out
that the i686 version ("32-bit") of Portable Git v2.45.1 is missing the
`package-versions.txt` file.

While it is unclear why that happened (the logs of the -- embargoed --
build do not reveal any clue about this issue), let's at least ensure
that it does not happen again.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@dscho
Copy link
Member Author

dscho commented May 17, 2024

@mcgitty any chance that you can review this?

Copy link

@mcgitty mcgitty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. It will force an investigation if it's missing in future builds.

@dscho dscho merged commit 1f3d963 into git-for-windows:main May 18, 2024
6 checks passed
@dscho dscho deleted the ensure-package-versions.txt-is-included-in-portable-git branch May 18, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

package-versions.txt file missing from build-extra and 2.45.1-32-bit.7z.exe
2 participants