add WritableToStream to easily write data from linop #1937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhmtsai
added
the
1:ST:need-feedback
ginkgo-bot
added
reg:testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR to allow that user write the data from the matrix (but LinOp pointer).
We have gko::write(ostream, mtx) to write the data out if the mtx is concrete matrix type.
This PR allows
as<gko::WritableToStream>(linop)->write(ostream)We can also provide something like gko::write(ostream, linop) if it makes things easy.
Because Dense, Fft, Diagonal have
WritableToMatrixData<..., int32>andWritableToMatrixData<..., int64>, I need to use virtual to contain only one copy.Any comment or alternative suggestion?
Dispatching to WriteToMatrixData in function will lose array default output for dense and fft (or doing another dispatching again there?)