Skip to content

Add a randomized Gram-Schmidt orthogonalization for GMRES #1930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 37 commits into
base: develop
Choose a base branch
from
Open

Add a randomized Gram-Schmidt orthogonalization for GMRES #1930

wants to merge 37 commits into from

Conversation

pratikvn
Copy link
Member

@pratikvn pratikvn commented Sep 17, 2025 •
edited
Loading

This PR adds a gmres::ortho_method::rgs strategy for GMRES. Like other strategies, this is also supported in a distributed setting.

Note: The rand-gmres example was added mostly as a easy way to check if the solver works, but can probably be removed.

TODO

  • Move theta setup and other allocations to generate/workspace.

thoasm and others added 30 commits September 8, 2025 18:03
@thoasm @pratikvn
Create template for the rand-gmres example
4c0c6a8
@thoasm @pratikvn
Add TODOs for future implementation
06c72ae
@venkovic @pratikvn
Added randomization helper structures.
3832011
@venkovic @pratikvn
Adding signature of restart_rgs kernel.
a7993b1
@venkovic @pratikvn
Changed _type for ValueType.
f636876
@venkovic @pratikvn
Added conditional call to make_restart_rgs.
31cf641
@venkovic @pratikvn
Finished implementation of restart_rgs.
b4c0fa4
@venkovic @pratikvn
Added signature for richardson_lsq kernel.
33f9e69
@venkovic @pratikvn
Added stub for richardson_lsq.
3e6ef29
@venkovic @pratikvn
Coded the reference richardson_lsq.
0a0670a
@venkovic @pratikvn
Corrected name of sketched_next_krylov2.
66c253b
@venkovic @pratikvn
Initialize hessenberg_iter.
9e1f2c6
@venkovic @pratikvn
Seeded random number generator with 123.
a1ee7d7
@venkovic @pratikvn
Finished debugging.
e4d3938
@venkovic @pratikvn
Set-up a new matrix for the example.
212c808
@venkovic @pratikvn
Added static cast of size_t num_rows.
5ce3531
@venkovic @pratikvn
Added two unit tests for rand-gmres.
cdc2cd5
@venkovic @pratikvn
Made a change to debug without warning.
888876f
@venkovic @pratikvn
Added spaces to structure test in 3 AAA parts.
f19173a
@venkovic @pratikvn
Added test with big matrix.
41ef7cd
@venkovic @pratikvn
Finished adding unit tests for RGS.
a13b662
@thoasm @pratikvn
Add Richardson test (still WIP)
1abb0a0
@thoasm @pratikvn
Fix Richardson test; Apply formatting
a38c2ff
@thoasm @pratikvn
Extend and fix Richardson test
48caa21
@thoasm @pratikvn
Add RestartRgs implementation with test
d79aae3 
Also extended the common tests to consider the RGS orthogonality.
Note: the richardson_lsq kernel is not implemented yet.
@thoasm @pratikvn
Add kernel implementation for richardson_lsq
492a961
@venkovic @pratikvn
add rgs in enum class ortho_method.
fe8896d
@venkovic @pratikvn
stream operator overload for rgs.
f3fc607
@venkovic @pratikvn
add nico as a ginkgo contributor
fdc22e8
@thoasm @pratikvn
Add Workspace support
e70a02a 
Make the temporary RGS vectors part of the workspace.
Only theta needs explicit local storage because it is not stored as
dense.

Additionally, fix the reference Richardson test.
@pratikvn pratikvn requested a review from a team September 17, 2025 07:21
@pratikvn pratikvn self-assigned this Sep 17, 2025
@pratikvn pratikvn added is:new-feature A request or implementation of a feature that does not exist yet. mod:core This is related to the core module. type:solver This is related to the solvers 1:ST:ready-for-review This PR is ready for review labels Sep 17, 2025
@ginkgo-bot ginkgo-bot added reg:build This is related to the build system. reg:testing This is related to testing. mod:cuda This is related to the CUDA module. mod:reference This is related to the reference module. reg:example This is related to the examples. reg:benchmarking This is related to benchmarking. mod:hip This is related to the HIP module. labels Sep 17, 2025
@pratikvn pratikvn added 1:ST:WIP This PR is a work in progress. Not ready for review. and removed 1:ST:ready-for-review This PR is ready for review labels Sep 22, 2025
@ginkgo-bot
Copy link
Member

Error: The following files need to be formatted:

dpcpp/factorization/par_ilut_select_kernel.dp.cpp
examples/CMakeLists.txt
examples/rand-gmres/CMakeLists.txt
examples/rand-gmres/doc/builds-on
examples/rand-gmres/rand-gmres.cpp

You can find a formatting patch under Artifacts here or run format! if you have write access to Ginkgo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@pratikvn pratikvn

Labels

1:ST:WIP This PR is a work in progress. Not ready for review. is:new-feature A request or implementation of a feature that does not exist yet. mod:core This is related to the core module. mod:cuda This is related to the CUDA module. mod:hip This is related to the HIP module. mod:reference This is related to the reference module. reg:benchmarking This is related to benchmarking. reg:build This is related to the build system. reg:example This is related to the examples. reg:testing This is related to testing. type:solver This is related to the solvers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pratikvn @ginkgo-bot @thoasm @venkovic