Fix std::pow on custom precision and clang dynamic_cast to final class issue #1924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhmtsai
added
1:ST:ready-for-review
ginkgo-bot
added
reg:build
MarcelKoch
approved these changes
Aug 28, 2025
yhmtsai
added
1:ST:ready-to-merge
3 tasks
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issues are raised by the ApplyClang 15->16 from updated github runner.
std::pow used bfloat16 as type before.
clang
dynamic_castto the class withfinalwill be failed.The issue is also mentioned in https://reviews.llvm.org/D154658 and the fix to Itanium ABI (not MS API) is included in clang 17.0.0.
We have also mentioned it in #1724