ginkgo_print_flags also print the common flag #1923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhmtsai
commented
Aug 27, 2025
Comment on lines
+67
to
+69
| if(DEFINED ${var_name}) | ||
| ginkgo_print_variable(${log_type} ${var_name}) | ||
| endif() |
There was a problem hiding this comment.
these three lines are the main changes. I swap the function such that ginkgo_print_variable is defined earlier than ginkgo_print_flags
MarcelKoch
requested changes
Aug 28, 2025
MarcelKoch
approved these changes
Aug 28, 2025
Co-authored-by: Marcel Koch <marcel.koch@kit.edu>
yhmtsai
force-pushed
the
improve_get_info
branch
from
eedaead to
e798fec
Compare
yhmtsai
added
1:ST:ready-to-merge
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the
ginkgo_print_flaginformation.Some flags contain build_type specific and common one used by all build type, such as CMAKE_CXX_FLAGS and CMAKE_CXX_FLAGS_RELEASE.
This will print the common flag if it is defined.