fix wrong condition with benchmark_from_scratch #1916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhmtsai
added
is:bugfix
ginkgo-bot
added
reg:benchmarking
pratikvn
requested changes
Aug 20, 2025
|
It is currently disabled by default -> the benchmark will reuse the same solver object |
yhmtsai
force-pushed
the
fix_missing_benchmark
branch
from
5125175 to
710011c
Compare
yhmtsai
commented
Aug 29, 2025
Comment on lines
-46
to
-49
| DEBUG: begin dense::fill | ||
| DEBUG: end dense::fill | ||
| DEBUG: begin dense::fill | ||
| DEBUG: end dense::fill |
There was a problem hiding this comment.
because we avoid reinitialization now
yhmtsai
commented
Aug 29, 2025
| DEBUG: begin dense::copy | ||
| DEBUG: end dense::copy | ||
| DEBUG: end copy(<typename>) | ||
| DEBUG: begin generate(<typename>) |
There was a problem hiding this comment.
first run before repetition to ensure workspace and constant are ready
- removal because we do clone twice when from scratch - addition because we perform first run ensuring workspace. repetition one are the same up to some initalization
yhmtsai
force-pushed
the
fix_missing_benchmark
branch
from
710011c to
631a010
Compare
yhmtsai
added
1:ST:ready-to-merge
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the wrong condition with
benchmark_from_scratchin #1881 .It should generate the one explicitly when we do not want to measure timing from scratch