1912/2 use new json input #1914
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginkgo-bot
added
reg:build
6 tasks
MarcelKoch
force-pushed
the
1912/2-use-new-json-input
branch
from
c801b03 to
1011d52
Compare
MarcelKoch
force-pushed
the
1912/1-item-schema
branch
from
8c2f622 to
d038e2b
Compare
MarcelKoch
force-pushed
the
1912/1-item-schema
branch
from
d038e2b to
c2ffa29
Compare
MarcelKoch
force-pushed
the
1912/2-use-new-json-input
branch
from
1011d52 to
09dbcb7
Compare
MarcelKoch
force-pushed
the
1912/2-use-new-json-input
branch
from
09dbcb7 to
d00af3d
Compare
MarcelKoch
force-pushed
the
1912/1-item-schema
branch
from
c2ffa29 to
9e06322
Compare
|
I will take a look at this later, but let me just say it's exciting to see such reductions in code complexity :) |
This flag doesn't make sense for the new json input, since a single matrix file is not enough to define a benchmark case for most benchmarks
MarcelKoch
force-pushed
the
1912/2-use-new-json-input
branch
from
d00af3d to
2756446
Compare
MarcelKoch
force-pushed
the
1912/1-item-schema
branch
from
9e06322 to
213ff21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the new JSON input in our benchmarks