[bench] add dense (add|sub)_diag to blas #1909
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcelKoch
force-pushed
the
benchmark-add_sub_diag
branch
from
0b7b92b to
8205148
Compare
yhmtsai
requested changes
Aug 13, 2025
| private: | ||
| std::unique_ptr<gko::matrix::Dense<etype>> alpha_; | ||
| std::unique_ptr<gko::LinOp> y_; | ||
| std::unique_ptr<gko::matrix::Diagonal<etype>> D_; |
There was a problem hiding this comment.
we need to make it to snake_case according to https://github.com/ginkgo-project/ginkgo/wiki/Contributing-guidelines#naming-scheme
There was a problem hiding this comment.
I think the naming scheme here should match the operation description in the CLI flag. I adjusted it accordingly.
MarcelKoch
force-pushed
the
benchmark-add_sub_diag
branch
from
8205148 to
ac150d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.