Fix MSVC with Intel MPI #1906
Merged
Fix MSVC with Intel MPI #1906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhmtsai
added
1:ST:ready-for-review
ginkgo-bot
added
reg:build
MarcelKoch
requested changes
Aug 6, 2025
pratikvn
reviewed
Aug 6, 2025
MarcelKoch
approved these changes
Aug 6, 2025
MSVC with /fpermissive- will mess up the funtion from wrong place
yhmtsai
added
1:ST:ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue when using MSVC with Intel MPI.
In distributed pgm, we use several lambda function and resolve the type on input type.
The type should be resolved when calling the function not defining, but MSVC tries to resolve it when defining it from the error log.
I need to enable
/permissive-to make it have more standard conformance behavior. more detail on/permissive-: https://learn.microsoft.com/en-us/cpp/build/reference/permissive-standards-conformance?view=msvc-170Alternatively, moving the lambda function to actual function might help.
However, it will give another issue when initializing some complex object during declaration.
From error log, it seems to consider function from the testing class not the variable class such that it failed at matching function.