-
Notifications
You must be signed in to change notification settings - Fork 99
create seperate timers for cpu and gpu #1905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
we also test the benchmark output. |
| }, | ||
| "gpu": {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems to has order effect in the test.
swapping "gpu" and "cpu" might solve it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also do the same thing for the generate
add several comment lines and explanation for documentation Co-authored-by: Yu-Hsiang M. Tsai <19565938+yhmtsai@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just notice that you only create cpu/gpu timer for apply but not for generation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Error: The following files need to be formatted: You can find a formatting patch under Artifacts here or run |
gpu timer and cpu timer are now 2 seperate timers