Skip to content

Conversation

@emre-safa
Copy link
Collaborator

gpu timer and cpu timer are now 2 seperate timers

@emre-safa emre-safa requested a review from yhmtsai August 1, 2025 09:25
@emre-safa emre-safa self-assigned this Aug 1, 2025
@emre-safa emre-safa added the 1:ST:ready-for-review This PR is ready for review label Aug 1, 2025
@ginkgo-bot ginkgo-bot added reg:benchmarking This is related to benchmarking. type:solver This is related to the solvers labels Aug 1, 2025
@yhmtsai yhmtsai requested a review from a team August 1, 2025 09:35
@yhmtsai
Copy link
Member

yhmtsai commented Aug 4, 2025

we also test the benchmark output.
you need to modify the *solver*.stdout in benchmark/test/reference.
it should be mostly "apply": { "components": { * } } to "apply": { "components": { "cpu": { * }, "gpu": {} } }

Comment on lines 43 to 44
},
"gpu": {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems to has order effect in the test.
swapping "gpu" and "cpu" might solve it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also do the same thing for the generate

emre-safa and others added 2 commits August 5, 2025 14:25
add several comment lines and explanation for documentation

Co-authored-by: Yu-Hsiang M. Tsai <19565938+yhmtsai@users.noreply.github.com>
Copy link
Member

@yhmtsai yhmtsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just notice that you only create cpu/gpu timer for apply but not for generation

Copy link
Member

@yhmtsai yhmtsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the current pr did what we discuss for two timer separately although it might need #1896 and #1897 such that the cpu timer get submission overhead only. I approve it but this pr should wait for another reviewer's approval because I involve it quite a lot.

@ginkgo-bot
Copy link
Member

Error: The following files need to be formatted:

core/base/extended_float.hpp

You can find a formatting patch under Artifacts here or run format! if you have write access to Ginkgo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1:ST:ready-for-review This PR is ready for review reg:benchmarking This is related to benchmarking. type:solver This is related to the solvers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants