Support METIS with built-in GKLib #1847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhmtsai
approved these changes
May 19, 2025
There was a problem hiding this comment.
LGTM. that will be great if @fritzgoebel can also confirm it works for his environment before merging this.
fritzgoebel
approved these changes
May 20, 2025
upsj
added
1:ST:ready-to-merge
|
I just tested, this works with both types of METIS builds, so I'll go ahead and merge it once CI is through |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1847 +/- ##
===========================================
- Coverage 89.65% 88.68% -0.97%
===========================================
Files 849 854 +5
Lines 70993 71221 +228
===========================================
- Hits 63647 63161 -486
- Misses 7346 8060 +714 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Error: PR already merged! |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we only supported METIS 5.x when it was exposed as two separate libraries libmetis.so and libGKLib.so
This is how METIS is available in Arch and when built manually, but Spack, Ubuntu, Rocky and others combine the two together into a single library.
cc @fritzgoebel