Skip to content

Conversation

MarcelKoch
Copy link
Member

This PR fixes the generation of the inverse of a neighborhood communicator. Instead of the one-sided communication, it uses an all-to-all communication.

Some MPI implementations seem to take issues with the one-sided implementation.

@MarcelKoch MarcelKoch added this to the Ginkgo 1.10.0 milestone May 15, 2025
@MarcelKoch MarcelKoch self-assigned this May 15, 2025
@MarcelKoch MarcelKoch added the 1:ST:ready-for-review This PR is ready for review label May 15, 2025
@ginkgo-bot ginkgo-bot added the mod:core This is related to the core module. label May 15, 2025
@MarcelKoch MarcelKoch requested a review from a team May 15, 2025 14:50
@pratikvn
Copy link
Member

Which MPI implementations have issues?

@MarcelKoch
Copy link
Member Author

@yhmtsai noticed it. Perhaps it's also based on UCX.

@yhmtsai
Copy link
Member

yhmtsai commented May 15, 2025

It is OpenMPI 5.0.3 with GCC 13.3.0 and UCX-CUDA
but it only introduces issue with certain #nodes and size.

Copy link
Member

@pratikvn pratikvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is used only when creating the neighborhood communicator, this is probably not a bottleneck and should be fine, but I think the doc needs to be updated. Otherwise, looks good to me.

const std::vector<comm_index_type>& ids,
const std::vector<comm_index_type>& sizes)
{
auto host_exec = exec->get_master();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the doc of the function needs to be updated ?

@MarcelKoch MarcelKoch force-pushed the fix-inverse-neighbor-comm branch from ca00b63 to 72356a8 Compare May 16, 2025 08:09
@MarcelKoch MarcelKoch requested a review from pratikvn May 16, 2025 08:12
Some MPI implementations seem to take issues with the one-sided implementation.

Co-authored-by: Pratik Nayak <pratik.nayak4@gmail.com>
@MarcelKoch MarcelKoch force-pushed the fix-inverse-neighbor-comm branch from 72356a8 to 1af3592 Compare May 19, 2025 14:06
@MarcelKoch MarcelKoch added 1:ST:ready-to-merge This PR is ready to merge. and removed 1:ST:ready-for-review This PR is ready for review labels May 20, 2025
Copy link

Copy link

codecov bot commented May 20, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 89.65%. Comparing base (d38eea1) to head (1af3592).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
core/distributed/neighborhood_communicator.cpp 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1842      +/-   ##
===========================================
+ Coverage    89.42%   89.65%   +0.22%     
===========================================
  Files          849      849              
  Lines        71023    70993      -30     
===========================================
+ Hits         63514    63647     +133     
+ Misses        7509     7346     -163     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MarcelKoch MarcelKoch merged commit f36107c into develop May 21, 2025
17 of 18 checks passed
@MarcelKoch MarcelKoch deleted the fix-inverse-neighbor-comm branch May 21, 2025 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1:ST:ready-to-merge This PR is ready to merge. mod:core This is related to the core module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants