-
Notifications
You must be signed in to change notification settings - Fork 99
Fix inverse neighborhood comm #1842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Which MPI implementations have issues? |
@yhmtsai noticed it. Perhaps it's also based on UCX. |
It is OpenMPI 5.0.3 with GCC 13.3.0 and UCX-CUDA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this is used only when creating the neighborhood communicator, this is probably not a bottleneck and should be fine, but I think the doc needs to be updated. Otherwise, looks good to me.
const std::vector<comm_index_type>& ids, | ||
const std::vector<comm_index_type>& sizes) | ||
{ | ||
auto host_exec = exec->get_master(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the doc of the function needs to be updated ?
ca00b63
to
72356a8
Compare
Some MPI implementations seem to take issues with the one-sided implementation. Co-authored-by: Pratik Nayak <pratik.nayak4@gmail.com>
72356a8
to
1af3592
Compare
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1842 +/- ##
===========================================
+ Coverage 89.42% 89.65% +0.22%
===========================================
Files 849 849
Lines 71023 70993 -30
===========================================
+ Hits 63514 63647 +133
+ Misses 7509 7346 -163 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This PR fixes the generation of the inverse of a neighborhood communicator. Instead of the one-sided communication, it uses an all-to-all communication.
Some MPI implementations seem to take issues with the one-sided implementation.