Skip to content

Add complex type support for hipBLAS GEAM #1839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025
Merged

Add complex type support for hipBLAS GEAM #1839

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions hip/base/hipblas_bindings.hip.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// SPDX-FileCopyrightText: 2017 - 2024 The Ginkgo authors
// SPDX-FileCopyrightText: 2017 - 2025 The Ginkgo authors
//
// SPDX-License-Identifier: BSD-3-Clause

Expand Down Expand Up @@ -119,7 +119,9 @@ GKO_BIND_HIPBLAS_GEMM(ValueType, detail::not_implemented);

GKO_BIND_HIPBLAS_GEAM(float, hipblasSgeam);
GKO_BIND_HIPBLAS_GEAM(double, hipblasDgeam);
// Hipblas does not provide geam complex version yet.
GKO_BIND_HIPBLAS_GEAM(std::complex<float>, hipblasCgeam);
GKO_BIND_HIPBLAS_GEAM(std::complex<double>, hipblasZgeam);

template <typename ValueType>
GKO_BIND_HIPBLAS_GEAM(ValueType, detail::not_implemented);

Expand Down
9 changes: 1 addition & 8 deletions test/matrix/dense_kernels.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// SPDX-FileCopyrightText: 2017 - 2024 The Ginkgo authors
// SPDX-FileCopyrightText: 2017 - 2025 The Ginkgo authors
//
// SPDX-License-Identifier: BSD-3-Clause

Expand Down Expand Up @@ -656,10 +656,6 @@ TEST_F(Dense, IsTransposableIntoDenseCrossExecutor)
}


// HIP doesn't support complex in all our supported versions yet
#ifndef GKO_COMPILING_HIP


TEST_F(Dense, IsConjugateTransposable)
{
set_up_apply_data();
Expand Down Expand Up @@ -692,9 +688,6 @@ TEST_F(Dense, IsConjugateTransposableIntoDenseCrossExecutor)
}


#endif


TEST_F(Dense, CopyRespectsStride)
{
set_up_vector_data(3);
Expand Down
5 changes: 1 addition & 4 deletions test/matrix/fbcsr_kernels.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,8 @@ class Fbcsr : public CommonTestFixture {
}
};

#ifdef GKO_COMPILING_HIP
TYPED_TEST_SUITE(Fbcsr, gko::test::RealValueTypes, TypenameNameGenerator);
#else
TYPED_TEST_SUITE(Fbcsr, gko::test::ValueTypes, TypenameNameGenerator);
#endif


TYPED_TEST(Fbcsr, CanWriteFromMatrixOnDevice)
{
Expand Down
Loading