Improved CSR-to-COO conversion #1832
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginkgo-bot
added
reg:build
upsj
force-pushed
the
bitvector
branch
4 times, most recently
from
0f06710 to
f0c5d97
Compare
upsj
force-pushed
the
improved_coo_conversion
branch
from
2d05e9f to
2d1113a
Compare
upsj
force-pushed
the
improved_coo_conversion
branch
from
2d1113a to
0f03ce2
Compare
upsj
force-pushed
the
transform_iterator
branch
2 times, most recently
from
34f6a8c to
a94c5a8
Compare
upsj
force-pushed
the
improved_coo_conversion
branch
from
0f03ce2 to
867c39a
Compare
yhmtsai
approved these changes
May 2, 2025
| const RowPtrType* ptrs, size_type num_blocks, | ||
| IndexType* idxs) | ||
| { | ||
| const auto num_elements = exec->copy_val_to_host(ptrs + num_blocks); |
There was a problem hiding this comment.
maybe we just paste the idxs size from outside. We should have it already when allocating the idxs array
| { | ||
| const auto num_elements = exec->copy_val_to_host(ptrs + num_blocks); | ||
| // transform the ptrs to a bitvector in unary delta encoding, i.e. | ||
| // every row with n elements is encoded as 1 0 ... n times ... 0 |
There was a problem hiding this comment.
Suggested change
| // every row with n elements is encoded as 1 0 ... n times ... 0 | |
| // every row with n elements is encoded as 1 0 ... n times ... 0 | |
| // we only process the value when bv is zero, the prefix-sum of bv - 1, which is get_rank() - 1, is the row index. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This conversion can suffer from load imbalance in imbalanced matrices, this new algorithm is always perfectly load-balanced.