Skip to content

Conversation

MarcelKoch
Copy link
Member

@MarcelKoch MarcelKoch commented Mar 14, 2025

This PR adds a distributed version of #1310. It only uses the non-local matrix to create the additional diagonal matrix which is added to the local matrix.

Todo:

  • parser test

@MarcelKoch MarcelKoch added the 1:ST:ready-for-review This PR is ready for review label Mar 14, 2025
@MarcelKoch MarcelKoch added this to the Ginkgo 1.10.0 milestone Mar 14, 2025
@MarcelKoch MarcelKoch requested a review from yhmtsai March 14, 2025 09:09
@MarcelKoch MarcelKoch self-assigned this Mar 14, 2025
@ginkgo-bot ginkgo-bot added reg:testing This is related to testing. mod:core This is related to the core module. mod:cuda This is related to the CUDA module. mod:reference This is related to the reference module. type:preconditioner This is related to the preconditioners type:matrix-format This is related to the Matrix formats mod:hip This is related to the HIP module. labels Mar 14, 2025
Signed-off-by: Marcel Koch <marcel.koch@kit.edu>
Copy link
Member

@yhmtsai yhmtsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the kernel needs to take care of device_type and can merge the previous one.
Others look good to me.

@MarcelKoch MarcelKoch added 1:ST:ready-to-merge This PR is ready to merge. and removed 1:ST:ready-for-review This PR is ready for review labels Mar 17, 2025
MarcelKoch and others added 2 commits March 18, 2025 09:28
Signed-off-by: Marcel Koch <marcel.koch@kit.edu>
- only provide kernel for absolute sum
- refactoring

Co-authored-by: Yu-Hsiang M. Tsai <yhmtsai@gmail.com>
Copy link

Copy link

codecov bot commented Mar 19, 2025

Codecov Report

Attention: Patch coverage is 98.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.31%. Comparing base (2acbcdd) to head (a218c9d).
Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
core/device_hooks/common_kernels.inc.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1806      +/-   ##
===========================================
+ Coverage    88.61%   89.31%   +0.69%     
===========================================
  Files          824      824              
  Lines        68776    68787      +11     
===========================================
+ Hits         60947    61438     +491     
+ Misses        7829     7349     -480     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MarcelKoch MarcelKoch merged commit e66d6d1 into develop Mar 19, 2025
15 of 18 checks passed
@MarcelKoch MarcelKoch deleted the l1-smoother branch March 19, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1:ST:ready-to-merge This PR is ready to merge. mod:core This is related to the core module. mod:cuda This is related to the CUDA module. mod:hip This is related to the HIP module. mod:reference This is related to the reference module. reg:testing This is related to testing. type:matrix-format This is related to the Matrix formats type:preconditioner This is related to the preconditioners

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants