Skip to content

Add pnode equality check (operator == and operator !=) #1801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 11, 2025
Merged

Add pnode equality check (operator == and operator !=) #1801

merged 3 commits into from
Mar 11, 2025

Conversation

yhmtsai
Copy link
Member

@yhmtsai yhmtsai commented Mar 5, 2025

This PR adds the pnode equality check. The equality of pnode only check the equality of current representing data.

@yhmtsai yhmtsai added 1:ST:ready-for-review This PR is ready for review 1:ST:skip-full-test labels Mar 5, 2025
@yhmtsai yhmtsai requested a review from MarcelKoch March 5, 2025 17:11
@yhmtsai yhmtsai self-assigned this Mar 5, 2025
@ginkgo-bot ginkgo-bot added reg:testing This is related to testing. mod:core This is related to the core module. labels Mar 5, 2025
@yhmtsai yhmtsai mentioned this pull request Mar 6, 2025
Merged
MarcelKoch
MarcelKoch requested changes Mar 10, 2025
View reviewed changes
Copy link
Member

@MarcelKoch MarcelKoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks good, just some comments on the tests.

upsj
upsj approved these changes Mar 11, 2025
View reviewed changes
Copy link
Member

@upsj upsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I agree with Marcel's suggestion for a map-inside-map test.

yhmtsai and others added 3 commits March 11, 2025 09:25
@yhmtsai yhmtsai requested a review from MarcelKoch March 11, 2025 08:25
@yhmtsai yhmtsai added 1:ST:ready-to-merge This PR is ready to merge. 1:ST:no-changelog-entry Skip the wiki check for changelog update labels Mar 11, 2025
@upsj upsj removed the 1:ST:ready-for-review This PR is ready for review label Mar 11, 2025
@yhmtsai yhmtsai merged commit 2acbcdd into develop Mar 11, 2025
11 checks passed
@yhmtsai yhmtsai deleted the pnode_equality branch March 11, 2025 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@upsj upsj upsj approved these changes

@MarcelKoch MarcelKoch MarcelKoch approved these changes

Assignees

@yhmtsai yhmtsai

Labels

1:ST:no-changelog-entry Skip the wiki check for changelog update 1:ST:ready-to-merge This PR is ready to merge. 1:ST:skip-full-test mod:core This is related to the core module. reg:testing This is related to testing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yhmtsai @upsj @MarcelKoch @ginkgo-bot