Skip to content

MPI_Comm cannot expected to be a pointer #1799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 5, 2025
Merged

MPI_Comm cannot expected to be a pointer #1799

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cac2102
[mpi] MPI_Comm cannot be expected to be pointer
pratikvn Feb 28, 2025
89af10c
[ci] enable mvapich job
pratikvn Mar 1, 2025
271556d
remove unnecessary null check
pratikvn Mar 4, 2025
733fb0b
[ci] fix typos
pratikvn Mar 4, 2025
06d5577
[ci] no multi-gpu runner available
pratikvn Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/_typos.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[files]
extend-exclude = ["third_party/*", "*.svg"]
extend-exclude = ["third_party/*", "*.svg", "*.bib", "CITING.md"]

[default.extend-words]
dout = "dout"
Expand Down
1 change: 1 addition & 0 deletions .gitlab-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ build/cuda110/nompi/gcc/cuda/release/shared:
variables:
BUILD_OMP: "ON"
BUILD_CUDA: "ON"
BUILD_MPI: "OFF"
BUILD_TYPE: "Release"
FAST_TESTS: "ON"
# fix gtest issue https://github.com/google/googletest/issues/3514
Expand Down
10 changes: 2 additions & 8 deletions include/ginkgo/core/base/mpi.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -567,9 +567,6 @@ class communicator {
*/
bool is_identical(const communicator& rhs) const
{
if (get() == nullptr || rhs.get() == nullptr) {
return get() == rhs.get();
}
if (get() == MPI_COMM_NULL || rhs.get() == MPI_COMM_NULL) {
return get() == rhs.get();
}
Expand All @@ -592,9 +589,6 @@ class communicator {
*/
bool is_congruent(const communicator& rhs) const
{
if (!get() || !rhs.get()) {
return get() == rhs.get();
}
if (get() == MPI_COMM_NULL || rhs.get() == MPI_COMM_NULL) {
return get() == rhs.get();
}
Expand Down Expand Up @@ -725,7 +719,7 @@ class communicator {
* Broadcast data from calling process to all ranks in the communicator
*
* @param exec The executor, on which the message buffer is located.
* @param buffer the buffer to broadcsat
* @param buffer the buffer to broadcast
* @param count the number of elements to broadcast
* @param root_rank the rank to broadcast from
*
Expand All @@ -748,7 +742,7 @@ class communicator {
* communicator
*
* @param exec The executor, on which the message buffer is located.
* @param buffer the buffer to broadcsat
* @param buffer the buffer to broadcast
* @param count the number of elements to broadcast
* @param root_rank the rank to broadcast from
*
Expand Down
Loading