Skip to content

Add logger for benchmark work estimate output #1784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: benchmark_work_estimate
Choose a base branch
from
Open

Add logger for benchmark work estimate output #1784

wants to merge 2 commits into from

Conversation

upsj
Copy link
Member

@upsj upsj commented Feb 16, 2025 •
edited
Loading

This adds another optional column to the ProfilerHook::create_(nested_)summary logger that computes memory bandwidths/FLOPS/custom rates for kernels with work estimates.

Merge stack:

@upsj upsj added the 1:ST:ready-for-review This PR is ready for review label Feb 16, 2025
@upsj upsj requested a review from a team February 16, 2025 20:20
@upsj upsj self-assigned this Feb 16, 2025
@ginkgo-bot ginkgo-bot added reg:build This is related to the build system. reg:testing This is related to testing. mod:core This is related to the core module. type:matrix-format This is related to the Matrix formats type:factorization This is related to the Factorizations reg:helper-scripts This issue/PR is related to the helper scripts mainly concerned with development of Ginkgo. labels Feb 16, 2025
@upsj upsj force-pushed the benchmark_work_estimate branch from 83a73da to 97aa307 Compare February 16, 2025 20:23
@upsj upsj mentioned this pull request Feb 16, 2025
Open
@upsj upsj force-pushed the benchmark_work_estimate_logger branch from 2bbe81b to eca15d0 Compare February 16, 2025 20:26
@upsj upsj force-pushed the benchmark_work_estimate branch from 97aa307 to c984d91 Compare February 20, 2025 11:24
@upsj upsj force-pushed the benchmark_work_estimate_logger branch from eca15d0 to 9ac9b8f Compare February 20, 2025 11:34
@MarcelKoch MarcelKoch self-requested a review February 20, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MarcelKoch MarcelKoch Awaiting requested review from MarcelKoch

Assignees

@upsj upsj

Labels

1:ST:ready-for-review This PR is ready for review mod:core This is related to the core module. reg:build This is related to the build system. reg:helper-scripts This issue/PR is related to the helper scripts mainly concerned with development of Ginkgo. reg:testing This is related to testing. type:factorization This is related to the Factorizations type:matrix-format This is related to the Matrix formats

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@upsj @ginkgo-bot