Skip to content

Conversation

yhmtsai
Copy link
Member

@yhmtsai yhmtsai commented Jan 16, 2025

This adds the two examples to show how to set up distributed multigrid
close #1768

@ginkgo-bot ginkgo-bot added reg:build This is related to the build system. reg:example This is related to the examples. labels Jan 16, 2025
@yhmtsai yhmtsai added the 1:ST:ready-for-review This PR is ready for review label Jan 16, 2025
@yhmtsai yhmtsai requested a review from a team January 16, 2025 08:32
@pratikvn
Copy link
Member

Are two examples necessary ? I think just one example (the customized one) should be sufficient. I think we discussed this earlier that we wanted to prevent having a lot of examples, but generally have tutorials which explain the creation of solvers/preconditioners rather than examples.

@yhmtsai yhmtsai force-pushed the distributed_mg_example branch from c180c49 to bac6cad Compare January 21, 2025 09:23
@MarcelKoch MarcelKoch self-requested a review February 13, 2025 13:03
Copy link
Member

@MarcelKoch MarcelKoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, mostly smaller notes on comments.

@yhmtsai yhmtsai requested a review from MarcelKoch February 13, 2025 15:13
@yhmtsai yhmtsai force-pushed the distributed_mg_example branch from f2e7253 to e2bab59 Compare February 13, 2025 15:22
@yhmtsai yhmtsai added 1:ST:ready-to-merge This PR is ready to merge. 1:ST:skip-full-test and removed 1:ST:ready-for-review This PR is ready for review labels Feb 18, 2025
@yhmtsai yhmtsai force-pushed the distributed_mg_example branch from e2bab59 to 4ad2178 Compare February 18, 2025 12:23
@yhmtsai yhmtsai merged commit e37369b into develop Feb 18, 2025
10 of 11 checks passed
@yhmtsai yhmtsai deleted the distributed_mg_example branch February 18, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1:ST:ready-to-merge This PR is ready to merge. 1:ST:skip-full-test reg:build This is related to the build system. reg:example This is related to the examples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Minimal implementation/example for a MPI-enabled multigrid-preconditioned-solver

4 participants