Add kernel for factorization validation #1766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginkgo-bot
added
reg:build
upsj
force-pushed
the
validate_factorization_kernel
branch
from
abc6c6b to
2eb2f6e
Compare
yhmtsai
requested changes
Jan 13, 2025
yhmtsai
approved these changes
Jan 13, 2025
upsj
added
1:ST:ready-to-merge
Co-authored-by: Yu-Hsiang M. Tsai <yhmtsai@gmail.com>
upsj
force-pushed
the
validate_factorization_kernel
branch
from
542cf16 to
37f8498
Compare
|
Error: PR already merged! |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this is being done sequentially. With the dedicated kernel, I can incorporate factorization validation into the entire benchmark workflow without a big performance penalty.