Skip to content

Conversation

yhmtsai
Copy link
Member

@yhmtsai yhmtsai commented Dec 11, 2024

As #1749, we do not support half precision in MSVC and MSYS2(MINGW) in Windows.
This PR disables it on these platforms

@yhmtsai yhmtsai added 1:ST:ready-for-review This PR is ready for review 1:ST:skip-full-test 1:ST:no-changelog-entry Skip the wiki check for changelog update labels Dec 11, 2024
@yhmtsai yhmtsai self-assigned this Dec 11, 2024
@ginkgo-bot ginkgo-bot added reg:build This is related to the build system. reg:documentation This is related to documentation. labels Dec 11, 2024
@yhmtsai yhmtsai changed the title disable half precision in mingw disable half precision in msys2 (mingw) Dec 11, 2024
@yhmtsai yhmtsai requested a review from a team December 11, 2024 15:14
@yhmtsai yhmtsai added the 1:ST:ready-to-merge This PR is ready to merge. label Dec 12, 2024
@yhmtsai yhmtsai merged commit d7e1450 into develop Dec 16, 2024
11 checks passed
@yhmtsai yhmtsai deleted the disable_mingw_half branch December 16, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1:ST:no-changelog-entry Skip the wiki check for changelog update 1:ST:ready-for-review This PR is ready for review 1:ST:ready-to-merge This PR is ready to merge. 1:ST:skip-full-test reg:build This is related to the build system. reg:documentation This is related to documentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants