Disable threadsanitizer temporarily #1735
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginkgo-bot
added
the
reg:ci-cd
yhmtsai
approved these changes
Nov 27, 2024
upsj
approved these changes
Nov 27, 2024
MarcelKoch
force-pushed
the
disable-threadsanitizer
branch
from
fedede5 to
aa03ce4
Compare
In its current state the threadsanitizer CI job has the following issues: - it's slow. The run can take >10h. Running it locally is much faster, so some configuration might be wrong. - false positives. Many tests fail, with either broken stack traces, or non locally reproducible output.
MarcelKoch
force-pushed
the
disable-threadsanitizer
branch
from
aa03ce4 to
4b4f1b6
Compare
|
Error: PR already merged! |
|
MarcelKoch
added a commit
to MarcelKoch/ginkgo
that referenced
this pull request
Dec 2, 2024
This PR disables the threadsanitizer CI job temporarily. In its current state, the threadsanitizer CI job has the following issues: - it's slow. The run can take >10h. Running it locally is much faster, so some configuration might be wrong. - false positives. Many tests fail, with either broken stack traces, or non-reproducible output. Related PR: ginkgo-project#1735
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR disables the threadsanitizer CI job temporarily. In its current state, the threadsanitizer CI job has the following issues: