Skip to content

Conversation

MarcelKoch
Copy link
Member

This PR fixes a compiler issue with cuda 11.0. This did not appear in cuda 11.4, so I replaced the 11.4 job with 11.0.

@MarcelKoch MarcelKoch added the 1:ST:ready-for-review This PR is ready for review label Nov 19, 2024
@MarcelKoch MarcelKoch added this to the Ginkgo 1.9.0 milestone Nov 19, 2024
@MarcelKoch MarcelKoch self-assigned this Nov 19, 2024
@ginkgo-bot ginkgo-bot added reg:ci-cd This is related to the continuous integration system. mod:cuda This is related to the CUDA module. type:preconditioner This is related to the preconditioners mod:hip This is related to the HIP module. type:factorization This is related to the Factorizations labels Nov 19, 2024
@MarcelKoch MarcelKoch added 1:ST:ready-to-merge This PR is ready to merge. and removed 1:ST:ready-for-review This PR is ready for review labels Nov 20, 2024
Copy link

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.37%. Comparing base (53bbc1d) to head (858d50a).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1729      +/-   ##
===========================================
+ Coverage    90.10%   90.37%   +0.27%     
===========================================
  Files          782      782              
  Lines        63475    63438      -37     
===========================================
+ Hits         57193    57335     +142     
+ Misses        6282     6103     -179     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@MarcelKoch MarcelKoch merged commit daa4b54 into develop Nov 20, 2024
13 of 14 checks passed
@MarcelKoch MarcelKoch deleted the fix-cuda-11.0 branch November 20, 2024 17:27
MarcelKoch added a commit to MarcelKoch/ginkgo that referenced this pull request Dec 2, 2024
This PR fixes a compiler issue with cuda 11.0. This did not appear in cuda 11.4, so I replaced the 11.4 job with 11.0.

Related PR: ginkgo-project#1729
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1:ST:ready-to-merge This PR is ready to merge. mod:cuda This is related to the CUDA module. mod:hip This is related to the HIP module. reg:ci-cd This is related to the continuous integration system. type:factorization This is related to the Factorizations type:preconditioner This is related to the preconditioners

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants