Always enable nlohmann_json with examples #1727
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pratikvn
added
1:ST:ready-for-review
ginkgo-bot
added
reg:build
upsj
requested changes
Nov 15, 2024
There was a problem hiding this comment.
find_package should ideally always happen on the topmost level, so that we don't look for different configurations accidentally. I would suggest moving the call to the root CMakeLists.txt. Is there a downside to always pulling in the dependency? I would like to avoid too many fragmented possible configurations depending on small environment differences.
Closed
+ It depends on nlohmann-json
pratikvn
force-pushed
the
example-fix-file-config
branch
from
49aba31 to
600417b
Compare
yhmtsai
reviewed
Nov 22, 2024
yhmtsai
approved these changes
Nov 22, 2024
pratikvn
added
1:ST:ready-to-merge
pratikvn
changed the title
upsj
approved these changes
Nov 23, 2024
Comment on lines
112
to
120
| foreach(executor IN LISTS executors) | ||
| add_test(NAME example_file-config-solver_${config_name}_${executor} | ||
| COMMAND | ||
| "$<TARGET_FILE:file-config-solver>" | ||
| "${executor}" "${CMAKE_CURRENT_SOURCE_DIR}/file-config-solver/config/${config_name}.json" | ||
| "${CMAKE_CURRENT_SOURCE_DIR}/file-config-solver/data/A.mtx" | ||
| WORKING_DIRECTORY | ||
| "$<TARGET_FILE_DIR:ginkgo>") | ||
| add_test(NAME example_file-config-solver_${config_name}_${executor} | ||
| COMMAND | ||
| "$<TARGET_FILE:file-config-solver>" | ||
| "${executor}" "${CMAKE_CURRENT_SOURCE_DIR}/file-config-solver/config/${config_name}.json" | ||
| "${CMAKE_CURRENT_SOURCE_DIR}/file-config-solver/data/A.mtx" | ||
| WORKING_DIRECTORY | ||
| "$<TARGET_FILE_DIR:ginkgo>") | ||
| # Prevent performance issues with high core counts |
There was a problem hiding this comment.
This doesn't actually change anything, right? I would just revert it then for a cleaner diff
MarcelKoch
pushed a commit
to MarcelKoch/ginkgo
that referenced
this pull request
Dec 2, 2024
Always enable nlohmann_json with examples Related PR: ginkgo-project#1727
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable the file-config example conditionally, as it depends on nlohmann-json.