-
Notifications
You must be signed in to change notification settings - Fork 99
Electrostatic amir #1714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Electrostatic amir #1714
Conversation
Thanks @amirbous! I think the explicit cast to So, you should be able to automatically run different solvers for both |
@amirbous What you describe with respect to |
@upsj , I think he is not using |
@upsj, @pratikvn Thank you for the check. |
. To reissue |
… changes and config file new options to readme file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks okay to me. If I can merge it, let me know.
// Warmup | ||
for (int i = 0; i < 3; ++i) { | ||
x_clone->copy_from(x.get()); | ||
solver->apply(b, x_clone); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can reduce the warmup here in line 150 to 1 instead of 3 to speed things up.
…s zero vector" This reverts commit 2e2bc08. Reverted to preserve formatting, and fix initializing null vector for initial guess
… for initial guess
I guess it should be ready now |
#example
Further work on code provided by @pratikvn going along with progress for using ginkgo in electrostatic
Structure and changes - all changes are done under example/electrostatic-abb:
Added new utils.hpp file to include user defined methods: read input from matrix file, read config file .... .
And moved some of the already existing functions to it
added readme.md for electrstatic specific usage
Purpose
Added Support for binary matrix files: added reader
Added config file (electrto.config) parser , to read parameters for Ginkgo configuration
Ginkgo configuration parameters are set in electro.config. More in the readme page for the electrostatic example
!! Warning !!:
Still uncertain about double and single precision as output files seem to be double precision in ascii format and single precision in binary format. For now when reading binary, reading as float and casting to double.