clean unused sycl version switch and change the badge #1702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhmtsai
added
1:ST:ready-for-review
ginkgo-bot
added
reg:documentation
pratikvn
approved these changes
Oct 18, 2024
yhmtsai
changed the title
MarcelKoch
approved these changes
Oct 21, 2024
yhmtsai
added
1:ST:ready-to-merge
MarcelKoch
pushed a commit
to MarcelKoch/ginkgo
that referenced
this pull request
Dec 2, 2024
… c++ badge This PR cleans unused sycl version switch and changes c++ badge Related PR: ginkgo-project#1702
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We support oneapi from 2023.1, whose __LIBSYCL_MAJOR_VERSION is already 6 (6.1.0 for __LIBSYCL).
This PR delete the dispatch before 6.
Also, change the c++14 badge to c++17 badge