Fix parameter ordering/naming for reference (omp) batch CG #1701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginkgo-bot
added
mod:reference
pratikvn
requested changes
Oct 18, 2024
pratikvn
approved these changes
Oct 22, 2024
|
I think we re-arranged it so that the convergence check is first. But I dont see a particular reason for that. I will maybe compare the performance for both and maybe unify the device side to the reference one as well. |
yhmtsai
added
1:ST:ready-to-merge
MarcelKoch
force-pushed
the
fix-batched-cg-ref
branch
from
7f77522 to
30c2d86
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1701 +/- ##
===========================================
+ Coverage 90.24% 92.05% +1.81%
===========================================
Files 764 764
Lines 62927 62678 -249
===========================================
+ Hits 56787 57701 +914
+ Misses 6140 4977 -1163 ☔ View full report in Codecov by Sentry. |
MarcelKoch
added a commit
to MarcelKoch/ginkgo
that referenced
this pull request
Dec 2, 2024
This merge fixes the parameter ordering of the `initialize` function for the reference+omp implementation of the batch CG. Additionally, a parameter name in `update_x_and_r` is changed to better reflect the actually used variable. Related PR: ginkgo-project#1701
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the parameter ordering of the
initializefunction for the reference+omp implementation of the batch CG. Additionally, a parameter name inupdate_x_and_ris changed to better reflect the actually used variable.