Fix complex solver benchmark #1692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginkgo-bot
added
reg:build
yhmtsai
approved these changes
Oct 23, 2024
- fix formatting Co-authored-by: Yu-Hsiang M. Tsai <19565938+yhmtsai@users.noreply.github.com>
MarcelKoch
force-pushed
the
fix-complex-benchmarks
branch
from
51e4fb7 to
8209132
Compare
upsj
approved these changes
Nov 5, 2024
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1692 +/- ##
===========================================
- Coverage 90.37% 90.32% -0.06%
===========================================
Files 782 782
Lines 63429 63442 +13
===========================================
- Hits 57326 57304 -22
- Misses 6103 6138 +35 ☔ View full report in Codecov by Sentry. |
MarcelKoch
added a commit
to MarcelKoch/ginkgo
that referenced
this pull request
Dec 2, 2024
This PR fixes the residual logging in the complex solver benchmark. In addition, tests for the `complex<double>` benchmarks are enabled for all benchmarks. Related PR: ginkgo-project#1692
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the residual logging in the complex solver benchmark. In addition, tests for the
complex<double>benchmarks are enabled for all benchmarks.