add workspace for reduction in residual norm #1687
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhmtsai
added
1:ST:ready-for-review
ginkgo-bot
added
mod:core
MarcelKoch
approved these changes
Oct 8, 2024
yhmtsai
force-pushed
the
residual_workspace
branch
from
e47918d to
1ed76a7
Compare
pratikvn
approved these changes
Oct 8, 2024
yhmtsai
added
1:ST:ready-to-merge
MarcelKoch
pushed a commit
to MarcelKoch/ginkgo
that referenced
this pull request
Dec 2, 2024
add workspace for reduction in residual norm, which avoid alloc/dealloc in the repeated call. Related PR: ginkgo-project#1687
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use compute_norm2 to compute the residual norm but miss the workspace.
In large matrix, we will repeatedly allocate and free for residual norm check.