Disable horeka CI jobs #1685
Merged
Disable horeka CI jobs #1685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginkgo-bot
added
the
reg:ci-cd
MarcelKoch
added
the
1:ST:no-changelog-entry
|
This should probably be rebased. Otherwise LGTM |
MarcelKoch
force-pushed
the
disable-horeka-jobs
branch
from
0db634a to
2de3a42
Compare
|
@upsj thanks for catching that. Maybe there is an option to make rebasing the default when updating a branch? |
|
Not AFAIK, but I recently talked to somebody from GitHub, I'll bring it up with him. |
upsj
approved these changes
Oct 2, 2024
yhmtsai
approved these changes
Oct 7, 2024
MarcelKoch
force-pushed
the
disable-horeka-jobs
branch
from
c829d6d to
0b38132
Compare
MarcelKoch
force-pushed
the
disable-horeka-jobs
branch
3 times, most recently
from
55fae31 to
acbd78b
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1685 +/- ##
===========================================
- Coverage 91.60% 90.00% -1.61%
===========================================
Files 761 763 +2
Lines 61199 62866 +1667
===========================================
+ Hits 56064 56580 +516
- Misses 5135 6286 +1151 ☔ View full report in Codecov by Sentry. |
MarcelKoch
force-pushed
the
disable-horeka-jobs
branch
from
acbd78b to
af84817
Compare
|
Error: PR already merged! |
MarcelKoch
added a commit
to MarcelKoch/ginkgo
that referenced
this pull request
Dec 2, 2024
This merge removes CI jobs on horeka. The QoL jobs are now executed on nla-gpu. In addition, it also deletes the windows github jobs. Related PR: ginkgo-project#1685
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR disables CI jobs on horeka. In time for the release I would like to have our CI pass all stages.
Edit:
This also deletes the windows github jobs, although it doesn't fit the original PR topic ideally.