Fix issues with distributed preconditioners, add to benchmarks #1660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginkgo-bot
added
mod:core
pratikvn
force-pushed
the
fix-distmg-perf
branch
from
d8f71a7 to
3ee8e1e
Compare
greole
reviewed
Aug 5, 2024
| GKO_ASSERT_EQ(level > 0, true); | ||
| auto last_mg_level = mg_level_list_.back(); | ||
|
|
||
| using ws = workspace_traits<Multigrid>; |
yhmtsai
requested changes
Aug 6, 2024
benchmark/utils/preconditioners.hpp
Outdated
| #ifdef GINKGO_BUILD_MPI | ||
| ", schwarz-jacobi, schwarz-ilu, schwarz-ic, schwarz-lu, dist-mg" | ||
| #endif | ||
| ""); |
benchmark/utils/preconditioners.hpp
Outdated
| .on(exec)); | ||
| return gko::solver::Multigrid::build() | ||
| .with_mg_level(gko::multigrid::Pgm<etype, itype>::build() | ||
| .with_deterministic(FLAGS_mg_deterministic)) |
There was a problem hiding this comment.
these flag are not available yet
This was referenced May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds benchmarking support for distributed preconditioners. It also fixes a few things that were causing increased allocations for distributed preconditioners.