Adds (S)SOR Preconditioner #1633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginkgo-bot
added
reg:build
Merged
MarcelKoch
force-pushed
the
sor
branch
3 times, most recently
from
499f37f to
f5b8d2a
Compare
MarcelKoch
force-pushed
the
sor
branch
3 times, most recently
from
97d4d54 to
f8cbc05
Compare
yhmtsai
requested changes
Jul 10, 2024
yhmtsai
approved these changes
Aug 5, 2024
yhmtsai
approved these changes
Aug 13, 2024
MarcelKoch
force-pushed
the
sor
branch
2 times, most recently
from
282ded2 to
64b4d55
Compare
fritzgoebel
approved these changes
Oct 24, 2024
fritzgoebel
reviewed
Oct 24, 2024
MarcelKoch
added
1:ST:ready-to-merge
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1633 +/- ##
===========================================
- Coverage 92.05% 90.33% -1.73%
===========================================
Files 764 776 +12
Lines 62678 63228 +550
===========================================
- Hits 57701 57116 -585
- Misses 4977 6112 +1135 ☔ View full report in Codecov by Sentry. |
only reference kernels are available
MarcelKoch
force-pushed
the
sor
branch
3 times, most recently
from
1cb476a to
363862f
Compare
- documentation - tests - don't build upper solver if not symmetric Co-authored-by: Yu-Hsiang M. Tsai <yhmtsai@gmail.com>
|
MarcelKoch
added a commit
to MarcelKoch/ginkgo
that referenced
this pull request
Dec 2, 2024
This merge adds the core and reference implementation of a (S)SOR preconditioner. It uses triangular solves to apply the preconditioner. The preconditioner is either a single lower triangular solver, or a lower triangular solve followed by an upper triangular one. Thus the preconditioner is represented as a `gko::Combination`. The `Sor` class itself is only a linop factory, similar to the `Lu` factorization. It can be parameterized by the `relaxation_factor` (`0 < w < 2`), symmetric or not (sym version has the two triangular solves), and the solver factories for the upper and lower triangular matrices. This also adds a Gauss-Seidel preconditioner as a special case of SOR. Related PR: ginkgo-project#1633
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the core and reference implementation of a (S)SOR preconditioner. It uses triangular solves to apply the preconditioner. The preconditioner is either a single lower triangular solver, or a lower triangular solve followed by an upper triangular one. Thus the preconditioner is represented as a
gko::Combination. TheSorclass itself is only a linop factory, similar to theLufactorization. It can be parameterized by therelaxation_factor(0 < w < 2), symmetric or not (sym version has the two triangular solves), and the solver factories for the upper and lower triangular matrices.This also adds a Gauss-Seidel preconditioner as a special case of SOR.
Todo: