Skip to content

Conversation

MarcelKoch
Copy link
Member

@MarcelKoch MarcelKoch commented Mar 25, 2024

@MarcelKoch MarcelKoch self-assigned this Mar 25, 2024
@ginkgo-bot ginkgo-bot added reg:build This is related to the build system. mod:cuda This is related to the CUDA module. mod:openmp This is related to the OpenMP module. mod:hip This is related to the HIP module. mod:dpcpp This is related to the DPC++ module. labels Mar 25, 2024
@MarcelKoch MarcelKoch mentioned this pull request Mar 25, 2024
6 tasks
@MarcelKoch MarcelKoch marked this pull request as draft March 25, 2024 10:35
@pratikvn pratikvn self-requested a review March 25, 2024 10:54
@MarcelKoch MarcelKoch force-pushed the index-map-device-kernels branch 4 times, most recently from c700b1c to 989967d Compare April 4, 2024 11:00
@MarcelKoch MarcelKoch added this to the Ginkgo 1.8.0 milestone Apr 5, 2024
@MarcelKoch MarcelKoch force-pushed the index-map-device-kernels branch from 989967d to cc997ff Compare April 19, 2024 14:39
@MarcelKoch MarcelKoch force-pushed the index-map-device-kernels branch 2 times, most recently from 989967d to cc997ff Compare April 25, 2024 07:18
@MarcelKoch MarcelKoch force-pushed the index-map-device-kernels branch from cc997ff to a8b5a65 Compare April 30, 2024 13:41
@MarcelKoch MarcelKoch marked this pull request as ready for review April 30, 2024 13:49
@MarcelKoch MarcelKoch force-pushed the index-map branch 2 times, most recently from f7fa971 to 95ab009 Compare May 7, 2024 12:51
@MarcelKoch MarcelKoch force-pushed the index-map-device-kernels branch from af79da4 to 14bff0e Compare May 7, 2024 12:51
Copy link
Member

@pratikvn pratikvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! A few minor things, which are mostly nits.

@MarcelKoch MarcelKoch force-pushed the index-map-device-kernels branch 5 times, most recently from 585009b to 80e2802 Compare May 8, 2024 18:53
@MarcelKoch MarcelKoch force-pushed the index-map-device-kernels branch from 80e2802 to 33d28fb Compare May 9, 2024 07:55
@MarcelKoch MarcelKoch force-pushed the index-map branch 2 times, most recently from 4e0efb4 to 92a2e8d Compare May 9, 2024 08:56
@MarcelKoch MarcelKoch force-pushed the index-map-device-kernels branch from 33d28fb to cdb0447 Compare May 9, 2024 08:56
@MarcelKoch MarcelKoch added 1:ST:ready-to-merge This PR is ready to merge. and removed 1:ST:ready-for-review This PR is ready for review labels May 10, 2024
@MarcelKoch MarcelKoch force-pushed the index-map-device-kernels branch from cdb0447 to abadebc Compare May 13, 2024 09:41
@MarcelKoch MarcelKoch force-pushed the index-map branch 2 times, most recently from 656bb7c to 4dc3658 Compare May 13, 2024 09:43
@MarcelKoch MarcelKoch force-pushed the index-map-device-kernels branch from abadebc to 8fb9d44 Compare May 13, 2024 09:43
Base automatically changed from index-map to develop May 13, 2024 20:48
@MarcelKoch MarcelKoch force-pushed the index-map-device-kernels branch from 8fb9d44 to fdb3ce2 Compare May 13, 2024 20:50
@MarcelKoch MarcelKoch force-pushed the index-map-device-kernels branch from fdb3ce2 to dff0aa8 Compare May 14, 2024 08:20
@MarcelKoch MarcelKoch merged commit d35f2e1 into develop May 14, 2024
@MarcelKoch MarcelKoch deleted the index-map-device-kernels branch May 14, 2024 13:13
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1:ST:ready-to-merge This PR is ready to merge. mod:cuda This is related to the CUDA module. mod:dpcpp This is related to the DPC++ module. mod:hip This is related to the HIP module. mod:openmp This is related to the OpenMP module. reg:build This is related to the build system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants