Skip to content

Conversation

yhmtsai
Copy link
Member

@yhmtsai yhmtsai commented Apr 20, 2022

This PR makes the preconditioner IC wrapper without SolverType. It moves the solver type into the factory operator.
When we provide the solver, the SolverType is useless but we still need to put it into template.
the type requirement is the same as original.
Ic<SolverType>::build().on(exec); -> IcWrapper::build().with_l_solver_factory(IcWrapper<SolverType>(exec)).on(exec)
or any IcWrapper::build().with_l_solver_factory(linop_factory).on(exec);
It's also good for ResourceManager.

TODO:

  • change the explicit type as when merging SolverBase
  • add IluWrapper

@ginkgo-bot ginkgo-bot added mod:core This is related to the core module. mod:reference This is related to the reference module. reg:build This is related to the build system. reg:testing This is related to testing. type:preconditioner This is related to the preconditioners labels Apr 20, 2022
@ginkgo-bot
Copy link
Member

Error: The following files need to be formatted:

test/test_install/test_install.cpp

You can find a formatting patch under Artifacts here or run format! if you have write access to Ginkgo

@ginkgo-bot
Copy link
Member

Note: This PR changes the Ginkgo ABI:

Functions changes summary: 0 Removed, 8 Changed (916 filtered out), 0 Added functions
Variables changes summary: 0 Removed, 0 Changed, 0 Added variable

For details check the full ABI diff under Artifacts here

@upsj
Copy link
Member

upsj commented Apr 21, 2022

The whole factorization preconditioner setup needs to be reworked (#472), do you need this urgently? I am not really happy with adding a second *Wrapper type that does the same thing and likely removing it with 2.0 again.

@yhmtsai yhmtsai added the 1:ST:low-importance This issue/PR is not that important and can be ignored for now. label May 23, 2022
@yhmtsai
Copy link
Member Author

yhmtsai commented May 8, 2025

close this in favor of #1811 and #1828 which use the same class as the current workaround

@yhmtsai yhmtsai closed this May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1:ST:low-importance This issue/PR is not that important and can be ignored for now. mod:core This is related to the core module. mod:reference This is related to the reference module. reg:build This is related to the build system. reg:testing This is related to testing. type:preconditioner This is related to the preconditioners

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants