Skip to content

Conversation

nbeams
Copy link
Collaborator

@nbeams nbeams commented May 7, 2025

cgeam and zgeam were added to hipBLAS in ROCm 3.6.0, so we can expand the hipBLAS bindings.

(Needed over in #1814)

@nbeams nbeams added 1:ST:ready-for-review This PR is ready for review mod:hip This is related to the HIP module. labels May 7, 2025
@nbeams nbeams force-pushed the add-complex-hipblas-geam branch from 9decfd8 to 6567180 Compare May 7, 2025 17:07
@nbeams
Copy link
Collaborator Author

nbeams commented May 8, 2025

Does this need an entry in the changelog, or not?

@upsj
Copy link
Member

upsj commented May 8, 2025

Do we have any public-facing function that uses it? Maybe dense complex transpose? In that case I would say yes, otherwise no.

@nbeams
Copy link
Collaborator Author

nbeams commented May 8, 2025

Hmm, yeah, it does look like it's used in dense transpose. I'll add it to the changelog, then -- once that's done, are there any complaints if I go ahead and merge this? wait, I guess that means I should also enable the transpose tests that are currently not done for HIP in this PR...

@nbeams
Copy link
Collaborator Author

nbeams commented May 8, 2025

For Fbcsr, I enabled all the tests for complex types, which passed when I tested locally (with the half precision tests skipped). For Dense, it was just the conjugate transpose tests that were guarded for HIP.

In the header file/doc strings for Fbcsr, I didn't see any specific note about it not being available for complex types with HIP, but since it wasn't tested, is that true? (I am wondering how much needs to go in the changelog.)

@yhmtsai
Copy link
Member

yhmtsai commented May 9, 2025

I think something like enable complex support of Dense transpose and FbCsr on AMD GPU in the changelog should be enough.

@nbeams nbeams force-pushed the add-complex-hipblas-geam branch from 298c451 to f8bde79 Compare May 14, 2025 13:32
@nbeams nbeams added 1:ST:ready-to-merge This PR is ready to merge. and removed 1:ST:ready-for-review This PR is ready for review labels May 14, 2025
@nbeams nbeams merged commit 4766cbf into develop May 14, 2025
13 of 15 checks passed
@nbeams nbeams deleted the add-complex-hipblas-geam branch May 14, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1:ST:ready-to-merge This PR is ready to merge. mod:hip This is related to the HIP module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants