[mach] Make section_by_name support loading sections starting with dot #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example `.rustc` used to be replaced with `__rustc` before searching, which meant `.rustc` was not findable
|
I think this is good (and I'd actually prefer if we got rid of this hack completely, but that's liable to break things). But maybe you should be naming the section |
|
The llvm backend uses |
mcbegamerxx954
pushed a commit
to mcbegamerxx954/object
that referenced
this pull request
Jun 15, 2024
[mach] Make section_by_name support loading sections starting with dot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example
.rustcused to be replaced with__rustcbefore searching, which meant.rustcwas not findablecc https://github.com/bjorn3/rustc_codegen_cranelift/pull/435