-
Notifications
You must be signed in to change notification settings - Fork 4.2k
ggml : suppress Windows compiler warnings #3075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The main problem is that the type conversion warnings are difficult to track when they are enabled only for Windows. We should either enable these warning for other compilers/environments and fix them all or disable the warning from the Windows builds. @slaren What do you think? |
Yeah, it is easy for them to sneak in as it is right now. I've added another commit which suppresses the warnings in whisper.cpp and with that there are no warnings on windows when building. I was almost done with this so I wanted to complete it just in case we want to use it. |
I think it would be better to disable the warning in MSVC in the cmake script, and remove all the |
I'll try to take a look at this next week 👍 |
This commit disables compiler warnings on window using MSVC. The motivation for these changes is that some compilers generate warnings for these conversion, for example Windows MSVC, and there are quite a few of them. This makes it a little difficult to spot new warnings that may be introduced and also can be difficult for users/embedders of ggml where these warnings are hard to separate from their own warnings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe the ggml
warnings should be disabled at the ggml
-level CMakeLists.
Yeah, that makes more sense. I'll move those related to |
Move ggml related warnings into ggml. This commit also fixes the indentation and adds a missing whitespace to the if statement.
This commit disables compiler warnings on window using MSVC.
The motivation for these changes is that some compilers generate
warnings for these conversion, for example Windows MSVC, and
there are quite a few of them. This makes it a little difficult to
spot new warnings that may be introduced and also can be difficult
for users/embedders of ggml where these warnings are hard to separate
from their own warnings.