ci : add build of wasm examples to CI #2959
Conversation
This commit add the building of the wasm examples to CI. Refs: ggml-org#2784
This commit adds src and include to the paths filter in the examples workflow. The motivation for this is that to avoid missing changes in src/include that may effect the examples we should also run them when src/include change.
|
CI run for wasm examples. I'll revert the dummy commit shortly. |
This reverts commit f657f22.
|
Thinking about this a little more perhaps there should be an examples-wasm.yml, examples-node.yml etc. The downside of what I've done here when adding to the existing examples.yml is that the addon.node example will also run when changes to the .wasm examples are made and vice versa, which is not great. Alternatively there are actions that can be used to provide more fine grained filtering per job like paths-changes-filter. |
|
We can improve the workflows if needed. The main requirement is that the CI is fast. It's OK if it sometimes triggers builds that are not related to the changes - as long as the triggered workflows are quick, then it's fine. |
I just realized that this is actually already covered by the emscripten job. I'll close this so that we don't duplicated this job.
I think that would be very nice, I'll take a look 👍 |
This commit add the building of the wasm examples to CI.
Refs: #2784