-
Notifications
You must be signed in to change notification settings - Fork 12.4k
convert-*.py: autogenerate general.uuid if missing #8565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
mofosyne
wants to merge
5
commits into
ggml-org:master
from
mofosyne:feature-convert-py-autogen-uuid
Closed
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
be8306d
convert-*.py: autogen uuid
mofosyne 0c49152
convert-*.py: Add source uuid generation
mofosyne 3fb690e
convert*.py: inline source uuid generation approach
mofosyne f05fa2a
Merge remote-tracking branch 'upstream/master' into feature-convert-p…
mofosyne 6db4f52
convert-*.py: hash pytorch array as numpy without type conversion (ex…
mofosyne File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While writing #8645 (comment), I've realized that this specific line is materializing the lazy tensors by reading their data, which would cause a very noticeable memory regression (making it no better than
--no-lazy
, which is not good RAM-usage-wise), at least when there is no UUID specified (which means, by default). This is because the data read is not immediately written (unlike inGGUFWriter.write_tensors_to_file
), so this puts all the tensors in memory before even writing the metadata.This will be more visible with models with
BF16
weights and/or MoE models, because their original tensors are not used as-is (type conversion and/or expert stacking) and so the output tensor list is nevermmap
-ed.If you can prove there is no memory regression, I'd be happy to dismiss this review.
(otherwise, be quick with
Ctrl
+C
(at least on Linux) to interrupt the conversion withSIGINT
, to avoid OOM)