Skip to content

[ROCm] Fix HIP version check for HIPBLAS V2 API compatibility #14744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+1 −1
Open

[ROCm] Fix HIP version check for HIPBLAS V2 API compatibility #14744

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e39c873
Fix HIP version check for HIPBLAS V2 API compatibility
danielholanda Jul 17, 2025
818bd27
Updating to 6.0.0 as suggested
danielholanda Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ggml/src/ggml-cuda/vendors/hip.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@
#define CUBLAS_STATUS_INTERNAL_ERROR HIPBLAS_STATUS_INTERNAL_ERROR
#define CUBLAS_STATUS_NOT_SUPPORTED HIPBLAS_STATUS_NOT_SUPPORTED

#if defined(__HIP_PLATFORM_AMD__) && HIP_VERSION >= 70000000
#if defined(__HIP_PLATFORM_AMD__) && HIP_VERSION >= 60000000
#define CUBLAS_COMPUTE_16F HIPBLAS_COMPUTE_16F
#define CUBLAS_COMPUTE_32F HIPBLAS_COMPUTE_32F
#define CUBLAS_COMPUTE_32F_FAST_16F HIPBLAS_COMPUTE_32F_FAST_16F
Expand Down