Skip to content

use max work group size for device to replace the magic number #14732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

use max work group size for device to replace the magic number #14732

wants to merge 1 commit into from
+5 −2

Conversation

NeoZhangJianyu
Copy link
Collaborator

Fix issue #14689
use max work group size for device to replace the magic number.
The magic number 768 is copied from CUDA code.

It will lead to issue "invalid work-group size" on Intel iGPU with less work group size.

@github-actions github-actions bot added ggml changes relating to the ggml tensor library for machine learning SYCL https://en.wikipedia.org/wiki/SYCL - GPU programming language labels Jul 17, 2025
Rbiessy
Rbiessy approved these changes Jul 17, 2025
View reviewed changes
Copy link
Collaborator

@Rbiessy Rbiessy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix that looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alcpz Alcpz Alcpz approved these changes

@qnixsynapse qnixsynapse qnixsynapse approved these changes

@Rbiessy Rbiessy Rbiessy approved these changes

Assignees
No one assigned
Labels
ggml changes relating to the ggml tensor library for machine learning SYCL https://en.wikipedia.org/wiki/SYCL - GPU programming language
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NeoZhangJianyu @Alcpz @qnixsynapse @Rbiessy