server: add prompt processing progress streaming for /completion endpoint #14685 #14728
+135
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oint - Add server_task_result_cmpl_progress struct for streaming progress updates - Implement send_progress_response() function for real-time progress reporting - Send progress info during prompt processing phase before token generation - Support all compatibility modes (non-OAI, OAI completion, OAI chat) - Include detailed progress data: n_past, n_prompt_tokens, n_prompt_tokens_processed, progress percentage - Only send progress updates in streaming mode (stream: true) - Maintains backward compatibility with existing clients Closes ggml-org#14685
ngxson
reviewed
Jul 16, 2025
No, this will breaks clients which assume the first response to be non-empty. |
|
As the feature requester, I would be happy with a flag in the request to send processing progress, default false. |
On backward compatibility: I understand that some clients may assume the first response contains content. I will reuse the existing server_task_result_cmpl_partial structure and make sure the progress field is only included when explicitly requested. Does that work ? |
|
Yes, and a small line explaining how it works is appreciated. It should be added to the documentation at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#14685
Closes #14685
Make sure to read the contributing guidelines before submitting a PR