Skip to content

CUDA: set_rows + cpy.cu refactor #14712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

am17an
Copy link
Collaborator

@am17an am17an commented Jul 16, 2025

To also support the rest of the quantized data-types in set-rows

Moving cpy functions to a common headers to re-use in set-rows, I will do get-rows next if this refactor seems the right direction. I feel we can still make the interface a little cleaner

@am17an am17an requested a review from JohannesGaessler July 16, 2025 05:26
@github-actions github-actions bot added Nvidia GPU Issues specific to Nvidia GPUs ggml changes relating to the ggml tensor library for machine learning labels Jul 16, 2025
@ggerganov ggerganov mentioned this pull request Jul 17, 2025
23 tasks
Copy link
Collaborator

@JohannesGaessler JohannesGaessler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Long-term we should rewrite the quantization code to make use of coalesced memory accesses. For an example, see quantize_q8_1 in quantize.cu, that kernel loads 32 contiguous floats and writes 32 contiguous bytes for the quantized values.

Nexesenex added a commit to Nexesenex/croco.cpp that referenced this pull request Jul 17, 2025
Updated for IKL IQ4_NL and Q6_0.

Original Author : Aman Gupta
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ggml changes relating to the ggml tensor library for machine learning Nvidia GPU Issues specific to Nvidia GPUs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants