common: add config presets for falcon #14638
Open
+16
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggerganov
reviewed
Jul 12, 2025
common/arg.cpp
Outdated
| {"--fim-falcon-7b-spec"}, | ||
| string_format("use quantized Falcon 7B model (note: can download weights from the internet)"), | ||
| [](common_params & params) { | ||
| params.model.hf_repo = "maddes8cht/tiiuae-falcon-7b-gguf"; |
There was a problem hiding this comment.
Presets should only use models hosted on ggml-org.
There was a problem hiding this comment.
ahh ok got it. I see that falcon is not in ggml-org, I will add another model then
common/arg.cpp
Outdated
| @@ -3423,5 +3423,21 @@ common_params_context common_params_parser_init(common_params & params, llama_ex | |||
| } | |||
| ).set_examples({LLAMA_EXAMPLE_SERVER})); | |||
|
|
|||
| add_opt(common_arg( | |||
| {"--fim-falcon-7b-spec"}, | |||
There was a problem hiding this comment.
This identifier is not correct. It indicates:
- A Fill-In-the-Middle (FIM) model
- Speculative-decoding enabled (i.e. target + draft model)
You can call it --chat-falcon-7b
common/arg.cpp
Outdated
| string_format("use quantized Falcon 7B model (note: can download weights from the internet)"), | ||
| [](common_params & params) { | ||
| params.model.hf_repo = "maddes8cht/tiiuae-falcon-7b-gguf"; | ||
| params.model.hf_file = "tiiuae-falcon-7b-Q6_K.gguf"; |
There was a problem hiding this comment.
We use Q8_0 format in the presets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added config presets for falcon -7b -instruct (using Q6_K)
towards #10932