Add support for google-benchmark #1237
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use git to checkout google-benchmark - add benchmark-mul-mat.cpp to benchmark matrix-matrix multiplication for three backends
|
@ggerganov Any feedback? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add initial support for Google Benchmark to GGML, which could lead to building a suite of benchmarks complementing the unit tests. This will allow contributors to work on GGML's performance and the various backends and maintainers to test for changes in performance over time.
I would also like to use the PR to discuss keeping external GGML dependencies small while including standard tools for benchmarking, testing, and logging.