Enable UTF-8 Source Encoding for MSVC via CMake #1226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slaren
reviewed
May 23, 2025
CMakeLists.txt
Outdated
Comment on lines
46
to
49
| if (MSVC) | ||
| add_compile_options("$<$<COMPILE_LANGUAGE:C>:/utf-8>") | ||
| add_compile_options("$<$<COMPILE_LANGUAGE:CXX>:/utf-8>") | ||
| endif() |
There was a problem hiding this comment.
There is already a if (MSVC) block at the bottom of this file, move this there to keep all the MSVC-specific settings together.
There was a problem hiding this comment.
You are correct, I will modify it according to your suggestion.
There was a problem hiding this comment.
There is already a
if (MSVC)block at the bottom of this file, move this there to keep all the MSVC-specific settings together.
Move /utf-8 and /bigobj into the existing if(MSVC) block before add_subdirectory(src) so that every ggml target inherits the flags automatically. This keeps all MSVC-specific settings together while still ensuring ggml-base and ggml see the flags during their creation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add conditional CMake compiler options so that when building with MSVC, both C and C++ sources are compiled with UTF-8 encoding (/utf-8). By default, MSVC uses the system code page and will warn (C4819) or fail when encountering non-ASCII characters in source files. This change eliminates those encoding warnings without requiring BOMs or pragmas in the code, ensures consistent UTF-8 handling across platforms, and keeps existing build processes for other toolchains unchanged.