fix: compile raw-gles example again after #6150
#6174
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MarijnS95 ☝🏻 |
|
Doesn't your CI catch this? Seems like I squashed this into the wrong PR (https://github.com/gfx-rs/wgpu/pull/6152/files#diff-ac2020a9d8bd724543c3bf9ff45b699d1ae9b15a9f6d77c38a604c7ff73cb716R19) as I was rebasing this from a Windows machine, which isn't supported in #6150 yet but only starting with #6152. |
6 tasks
|
@MarijnS95: I'm not sure why our CI doesn't catch it. @cwfitzgerald, is there a reason CI doesn't at least try to compile examples? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
I think this was regressed by #6150?
Description
See above.
Testing
It compiles now!
Checklist
Run
cargo fmt.Run
cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptenRun
cargo xtask testto run tests.Add change to
CHANGELOG.md. See simple instructions inside file.Probably not necessary? Might want to add on to the
glutinCHANGELOGentry. 🤔