[d3d12] add a shader cache to avoid calling into DXC/FXC #7729
+93
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimblandy
requested changes
May 27, 2025
|
I updated the PR with the implementation that we talked about but it's not actually a static cap since we will "retain all entries that have been used since we compiled the last 100 shaders". Even though it's not a static cap it sounds like the right approach since the cache will contain the the latest used shaders in it. Let me know what you think! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Closes #7716.
Description
Adds a shader cache to the D3D12 backend so that we don't have to recompile shaders via DXC/FXC.
Note that the cache is per device and so will get cleared when the device is dropped. I think this is fine for now.
Testing
Tested manually.
Squash or Rebase?
n/a